1. Posted by Erwyn on Sat, 21 Jun 2008 10:43:52

    Hey everyone,

    I've been playing around trying to measure some damagetypes with a modified CombatTracker addon, not very succesfully initially.

    The return values for the damagetype argument in the UNIT_COMBAT event are not

    0 - physical; 1 - holy; 2 - fire; 3 - nature; 4 - frost; 5 - shadow; 6 - arcane

    as mentioned in the book or in the API reference.

    Actually, there's some binary stuff behind that and the numeric values represent the power of 2.

    0 - physical = 2^0 = 1 1 - holy = 2^1 = 2 2 - fire = 2^2 = 4 3 - nature = 2^3 = 8 4 - frost = 2^4 = 16 5 - shadow = 2^5 = 32 6 - arcane = 2^6 = 64

    In my addon I now query for 1, 2, 4, 8, 16, 32 and 64 and it works like a charm.

    Sorry if that was already a well-known fact. It's just that I had one of those "ahhhhhhhh" moments yesterday after an hour of testing with the Dev Tools and doing some dailies :-)

    Kind regards, Erwyn

  2. Posted by Erwyn on Tue, 10 Jun 2008 06:56:54

    I am sorry for the poor formatting, I tried editing my post before, but it didn't allow me to do so.

    Erwyn

  3. Posted by jnwhiteh on Tue, 10 Jun 2008 09:01:36

    Just a few things.  The change to UNIT_COMBAT are due to the combat log revamp that happened in 2.4 which was unfortunately after the book was released.  We're working to get as much of the API up to date as possible, but as you can imagine it involved quite a number of functions.

    Regarding the formatting of your post, I'd love if you could post some more information about the browser/setup that you're using to post.  The forums use a javascript editor to generate HTML based on user input, so if you have javascript disabled you would run into issues like you've seen.  Also, the editing bug is one I'm aware of and need to get fixed, thanks for the report!

  4. Posted by Erwyn on Wed, 11 Jun 2008 20:35:18

    Hi again,

    okay, thanks for the clarification :-)

    I am running IE 7 with Avant Browser and had Java enabled actually. The page is throwing a Javascript error in line 39, character 1. I could post the German error message if that'd help you?!

    I tried loading the page in Firefox as well and there I could see the formatting bar - in IE 7 it's just not displayed.

    Kind regards, Erwyn

  5. Posted by jnwhiteh on Wed, 11 Jun 2008 21:12:53
    Hi again, okay, thanks for the clarification :-) I am running IE 7 with Avant Browser and had Java enabled actually. The page is throwing a Javascript error in line 39, character 1. I could post the German error message if that'd help you?! I tried loading the page in Firefox as well and there I could see the formatting bar - in IE 7 it's just not displayed. Kind regards, Erwyn

    Yeah, if you could post the javascript error message that would be great!

  6. Posted by Erwyn on Thu, 12 Jun 2008 05:47:30

    Okay, here we go:

    ---zip---

    Die aktuelle Seite enthält 1 Skriptfehler.

    Zeile: 39

    Zeichen: 1

    Code: 0

    Fehler: Bezeichner, Zeichenfolge oder Zahl erwartet.

    URL: http://wowprogramming.com/forums/book/52/reply

    ---zap----

    Hope this helps!

    Kind regards, Erwyn

  7. Posted by jnwhiteh on Sat, 14 Jun 2008 15:42:36

    Hrm, I think I've fixed this issue.  Can you try posting a reply and see if you get the WYSIWYG editor?

  8. Posted by Erwyn on Sat, 21 Jun 2008 10:43:52

    Yes, it's fixed.

    I can format my posts now :-)